[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] calling diff_summarize from SVN Perl bindings

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 18 Jan 2009 20:03:13 +0200 (Jerusalem Standard Time)

Please wait a little bit more than just one weekend before deciding your
patch was ignored. :-)

Also, a couple of stylistic bugs while I'm here:

* Please write patches against trunk. (And if not against trunk, do
  indicate that at the time you post them.)

* Use spaces, not tabs.

Thanks for the patch,

Daniel

James Fang wrote on Sun, 18 Jan 2009 at 20:46 +0800:
> hi, sorry to interrupt.
> can you apply this patch so that it may come up in the next subversion
> release?
> because one of our system rely on the diff_summarize from Perl. we do not
> want to
> apply the patch ourself and build our own RPM packages when there are new
> SVN
> release.
> this patch is against the 1.5.4 release, and i have tested it on CentOS
> 5.2.
>
> On Thu, Jan 15, 2009 at 6:00 PM, James Fang <june.fang_at_gmail.com> wrote:
>
> > [[[
> > Make diff_summarize callable from Perl binding.
> >
> > [in subversion/bindings/swig]
> > * svn_client.i
> > Add typemap for (svn_client_diff_summarize_func_t, void*) arguments
> > sequence.
> > * perl/libsvn_swig_perl/swigutil_pl.h
> > Declare svn_swig_pl_thunk_client_diff_summarize_func as callback
> > thunk.
> > * perl/libsvn_swig_perl/swigutil_pl.c
> > Define svn_swig_pl_thunk_client_diff_summarize_func as callback
> > thunk.
> > * perl/native/Client.pm
> > Add document for diff_summarize method;
> > Expose svn_client_diff_summarize_kind_t as
> > SVN::Client::Summarize::*.
> > ]]]
> >
> >
> > On Sat, Dec 27, 2008 at 6:06 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name>wrote:
> >
> >> James Fang wrote on Thu, 27 Nov 2008 at 16:49 +0800:
> >> > at least in Perl, the SVN::Client::diff_summarize can not be invoke(
> >> it
> >> > reports illegal argument error).
> >> > i find the problem lies in that the "svn_client_diff_summarize_func_t"
> >> type
> >> > lacks the corresponding
> >> > SWIG declaration( compared with "svn_log_message_receiver")
> >>
> >> ...
> >>
> >> > since i am new to SWIG and Perl, i can not get to a ideal solution yet.
> >> I
> >> > just manual edited the
> >> > swig/perl/native/svn_client.c,
> >> > swig/perl/native/Core.pm,
> >> > swig/libsvn_swig_perl/swigutil_pl.c to get it worked.
> >> > But this is obvious a temporary solution, is there any plan for a more
> >> > complete language bindings?
> >> >
> >>
> >> I don't know anyone specifically working on that at the moment. However,
> >> since you already did the work to support those APIs, could you repackage
> >> it as a patch and send it to dev@? (Please read [1] before doing so.)
> >>
> >> Thanks,
> >>
> >> Daniel
> >>
> >> [1] http://subversion.tigris.org/hacking.html#patches
> >>
> >> >
> >> >
> >>
> >
> >
> >
> > --
> > James Fang
> >
>
>
>
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1033028
Received on 2009-01-18 20:43:09 CET

This is an archived mail posted to the Subversion Dev mailing list.