On Sat, Jan 17, 2009 at 04:11:00AM +0000, Stefan Sperling wrote:
> On Fri, Jan 16, 2009 at 09:37:54PM -0600, Hyrum K. Wright wrote:
> > Stefan Sperling wrote:
> > > Author: stsp
> > > Date: Fri Jan 16 16:56:45 2009
> > > New Revision: 35295
> > >
> > > Log:
> > > Break up svn_wc__merge_internal() into many smaller functions.
> > >
> > > There's still room for improvement.
> > > Some of the new functions take an insane amount of parameters,
> > > these lack docstrings because I was too lazy^W busy to document
> > > them. But the code is already much more readable.
> > > And make check is still happy, except:
> > > FAIL: fs-pack-test 1: pack a FSFS filesystem
> > > which should be unrelated to this change.
> >
> > ...and which I could not reproduce locally. Does anybody else see this failure?
>
> More detail:
>
> $ ./fs-pack-test --verbose 1
> subversion/libsvn_subr/io.c:2636: (apr_err=24)
> svn_tests: Can't open file 'test-repo-fsfs-pack/transactions/34-y.txn/changes': Too many open files
> FAIL: fs-pack-test 1: pack a FSFS filesystem
>
> Probably related to this:
> $ ulimit -a | grep files
> open files (-n) 128
>
> Does the test create more than 128 files? :)
>
> I should probably tweak that setting.
Yes, allowing 512 open file descriptors makes this test pass for me,
too.
Stefan
Received on 2009-01-17 14:05:22 CET