[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35268 - in trunk: build/ac-macros subversion/libsvn_subr

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 16 Jan 2009 08:01:01 -0600

Greg Stein wrote:
> On Thu, Jan 15, 2009 at 21:09, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
>> ...
>> +++ trunk/build/ac-macros/sqlite.m4 Thu Jan 15 12:09:00 2009 (r35268)
>> @@ -61,8 +61,8 @@ AC_DEFUN(SVN_LIB_SQLITE,
>> fi
>>
>> if test -z "$svn_lib_sqlite"; then
>> - dnl finally, see if the sqlite amalgamation
>> - SVN_SQLITE_FILE_CONFIG(build/sqlite3.c)
>> + dnl finally, see if the sqlite amalgamation exists
>> + SVN_SQLITE_FILE_CONFIG(`pwd`/sqlite-amalgamation/sqlite3.c)
>
> Shouldn't use pwd. If you look at neon.m4, it uses $abs_srcdir.
>
> As an experiment, do the following:
>
> $ svn co $SVN svn
> $ [add deps into svn/FOO]
> $ mkdir mybuild
> $ cd mybuild
> $ ../trunk/svn/configure --switches
>
> You should be able to build svn without touching or creating any files
> in svn/. And it should be able to pick up all deps from there, too.
>
>> fi
>>
>> if test -z "$svn_lib_sqlite"; then
>> @@ -108,6 +108,9 @@ AC_DEFUN(SVN_SQLITE_DIR_CONFIG,
>> [
>> sqlite_dir="$1"
>>
>> + AC_MSG_CHECKING([sqlite library in $sqlite_dir])
>> + echo ""
>
> I don't think you're supposed to use "echo" within autoconf. It
> mangles stdout and crap like that, so not a good idea. What is the
> echo for?

Add an extra line break. We do use echo in our autoconf scripts, mainly to
output the fancy-schmancy text about where to download sqlite before bombing out.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1028641
Received on 2009-01-16 15:01:26 CET

This is an archived mail posted to the Subversion Dev mailing list.