[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35144 - trunk/subversion/include

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Mon, 12 Jan 2009 13:18:38 +0000

On Sun, 2009-01-11 at 05:14 -0800, Bert Huijben wrote:
> Author: rhuijben
> Date: Sun Jan 11 05:14:59 2009
> New Revision: 35144
>
> Log:
> * subversion/include/svn_error.h
> (SVN_ERR_MALFUNCTION_NO_RETURN): Make the loop containing abort() run
> infinately to help compilers that don't recognize abort() behavior
> see that this code never returns.
>
> Modified:
> trunk/subversion/include/svn_error.h
>
> Modified: trunk/subversion/include/svn_error.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_error.h?pathrev=35144&r1=35143&r2=35144
> ==============================================================================
> --- trunk/subversion/include/svn_error.h Sat Jan 10 15:54:46 2009 (r35143)
> +++ trunk/subversion/include/svn_error.h Sun Jan 11 05:14:59 2009 (r35144)
> @@ -365,7 +365,7 @@ svn_handle_warning(FILE *stream,
> do { \
> svn_error__malfunction(FALSE, __FILE__, __LINE__, NULL); \
> abort(); \
> - } while (0)
> + } while (1)
>

Please add a comment explaining that, as otherwise that code looks
wrong.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1019033
Received on 2009-01-12 14:27:16 CET

This is an archived mail posted to the Subversion Dev mailing list.