[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35103 - in trunk/subversion: include libsvn_client libsvn_delta libsvn_fs libsvn_fs_base libsvn_fs_base/bdb libsvn_fs_base/util libsvn_fs_fs libsvn_subr libsvn_wc tests/libsvn_delta

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 9 Jan 2009 06:24:25 -0800

On Fri, Jan 9, 2009 at 05:52, Julian Foad <julianfoad_at_btopenworld.com> wrote:
> So, the svn_checksum_t internals are going to be public. Should we make
> the "digest" field publically writable? If we don't, there's no public
> official way to initialize the allocated memory, but there could be
> public APIs for doing so in the future. That's probably a reasonable
> position to be in.

It used to be non-const, but hwright constified it a while back. The
idea was that our APIs would write into it, but third-party users
should not. Thus, const.

The "public" way to create one is via finalizing a context, parsing
hex data, computing a checksum for a byte block, etc. Just no real way
to shove bytes into that structure explicitly.

There is an argument that third parties will need __from_digest just
like we do, as they upgrade from the old digest-style APIs. I'd
consider waiting to hear from them before officially
supporting/exposing that API.

Received on 2009-01-09 15:24:46 CET

This is an archived mail posted to the Subversion Dev mailing list.