On Thu, Jan 8, 2009 at 4:37 PM, Paul Burba <ptburba_at_gmail.com> wrote:
> [snip]
> The hanging tests on my machine (and I hope DJ's buildbot) were caused
> by Arferver's change to subprocess.Popen()/subprocess.Popen.wait() in
> r34863. After that change, when running the tests in parallel there
> was a deadlock when prop_tests.py 10 'try to set inappropriate props'
> tries a whole slew of invalid propsets, producing a lot of stderr...at
> least that's what appears to have been happening. Per the Python docs
> this as a known/common problem with Popen.wait():
>
> Warning - This will deadlock if the child process generates enough output
> to a stdout or stderr pipe such that it blocks waiting for the OS pipe
> buffer to accept more data. Use communicate() to avoid that.
>
> So I switched from subprocess.Popen.wait() to
> subprocess.Popen.communicate() in r35093 and that fixed the problem
> (though it wasn't quite so simple as that).
>
> Paul
>
>
Thanks for looking into and taking care of these, Paul! I'll have the
buildbot running again tomorrow.
DJ
Received on 2009-01-09 06:33:51 CET