[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r35055 - in trunk/subversion: include libsvn_auth_gnome_keyring libsvn_subr

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Thu, 08 Jan 2009 14:45:55 +0530

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Bert,

Bert Huijben wrote:
> This method is generic for gui clients and commandline clients. This method should get the prompt handler from above instead of just choosing a cmdline implementation for the prompt handler.
>
> svn_auth_get_platform_specific_provider should not register cmdline handlers, or javahl, the python and ruby bindings must be changed to no longer use this method.
>
> See also its documentation:
> ==========================
> /** Create and return @a *provider, an authentication provider of type @c
> * svn_auth_provider_object_t, or return @a NULL if the provider is not
> * available for the requested platform or the requested provider is unknown.
> *
> * Valid @a provider_name values are: "gnome_keyring", "keychain", "kwallet"
> * and "windows".
> *
> * Valid @a provider_type values are: "simple", "ssl_client_cert_pw" and
> * "ssl_server_trust".
> *
> * Allocate @a *provider in @a pool.
> *
> * What actually happens is we invoke the appropriate provider function to
> * supply the @a provider, like so:
> *
> * svn_auth_get_<name>_<type>_provider(@a provider, @a pool);
> *
> * @since New in 1.6.
> */
> svn_error_t *
> svn_auth_get_platform_specific_provider(svn_auth_provider_object_t **provider,
> const char *provider_name,
> const char *provider_type,
> apr_pool_t *pool);
>
> ============================
>
> It says nothing about being cmdline specific, but calling this method will register a cmdline prompt now.

I could not think of any better idea in order to implement it. Can you help me
in pointing out how we can go about? Or shall we document saying
"svn_auth_get_platform_specific_provider" should not be used by gui clients?

Thank You.
- --
Senthil Kumaran S
http://www.stylesen.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFJZcRJ9o1G+2zNQDgRAvYoAJ4p0uPsUVDWkP1O63kWHP54rp0O7ACgjAxD
m+qGpMW+KB/xdByu7oAc68U=
=hB65
-----END PGP SIGNATURE-----

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1011341
Received on 2009-01-08 10:16:24 CET

This is an archived mail posted to the Subversion Dev mailing list.