Re: '--with-berkeley-db' option [Re: svn commit: r35017 - build/ac-macros]

Arfrever Frehtes Taifersar Arahesis wrote:
> >> - svn_apu_bdb_lib=["`$apu_config --libs | sed -e 's/.*\(-ldb[^ ]*\).*/\1/'`"]
> >> + SVN_DB_LIBS=["${SVN_DB_LIBS-`$apu_config --libs | $GREP -o -- '-ldb[^[:space:]]*'`}"]
> >
> > Is the change from the "sed" command to the "$GREP -o" command
> > necessary? It looks to me like it is just another way of writing the
> > same thing. If so, I think we should change it back to the "sed" form.
>
> The 'sed' version works incorrectly when `$apu_config --libs` doesn't
> contain '-ldb[^[:space:]]*' (which does NOT mean that APR-Util is
> built without support for Berkeley DB. (r35017 was required to build
> support for Berkeley DB when using APR-Util 1.4.)).

I edited r35017's log message to include this information.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1010124
Received on 2009-01-07 17:27:44 CET