[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: '--with-berkeley-db' option [Re: svn commit: r35017 - build/ac-macros]

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 07 Jan 2009 01:25:24 +0000

Arfrever Frehtes Taifersar Arahesis wrote:
> 2009-01-05 21:33 Julian Foad <julianfoad_at_btopenworld.com> napisaƂ(a):
> >> Author: arfrever
> >> Date: Fri Jan 2 18:53:25 2009
> >> New Revision: 35017
> >>
> >> Log:
> >> Don't ignore optional argument of the '--with-berkeley-db' option.
> >>
> >> * build/ac-macros/berkeley-db.m4
> >> (SVN_LIB_BERKELEY_DB, SVN_LIB_BERKELEY_DB_TRY): Don't ignore optional
> >> argument of the '--with-berkeley-db' option.
> >
> > This change (with r35021, just a tweak to it) breaks detection of BDB on
> > my system:
[...]
> > (Here I am showing the diff of r35017 and r35021 combined together.)
> >
> >> Index: build/ac-macros/berkeley-db.m4
> >> ===================================================================
> >> --- build/ac-macros/berkeley-db.m4 (revision 35016)
> >> +++ build/ac-macros/berkeley-db.m4 (working copy)
> >> @@ -42,7 +42,7 @@ AC_DEFUN(SVN_LIB_BERKELEY_DB,
> >> dnl for headers in HEADER and libraries in LIB.
> >>
> >> AC_ARG_WITH(berkeley-db, [AS_HELP_STRING(
> >> - [--with-berkeley-db=PATH], [
> >> + [[--with-berkeley-db=[INCLUDES:LIB_SEARCH_DIRS:LIBS]]], [
> >> The Subversion Berkeley DB based filesystem library
> >> requires Berkeley DB $db_version or newer. If you
> >> specify `--without-berkeley-db', that library will
> >> @@ -64,7 +64,7 @@ AC_DEFUN(SVN_LIB_BERKELEY_DB,
> >> [
> >> if test "$withval" = "no"; then
> >> status=skip
> >> - else
> >> + elif test "$withval" = "yes"; then
> >> apu_db_version="`$apu_config --db-version`"
> >> if test $? -ne 0; then
> >> AC_MSG_ERROR([Can't determine whether apr-util is linked against a
> >> @@ -86,11 +86,27 @@ AC_DEFUN(SVN_LIB_BERKELEY_DB,
> >> possible to use the specified Berkeley DB: $withval])
> >> fi
> >>
> >> - AC_MSG_WARN([APR-UTIL may or may not be using the specified
> >> - Berkeley DB at `$withval'. Using the Berkeley DB
> >> - supplied by APR-UTIL.])
> >> + status=required
> >> + fi
> >> + else
> >> + if test -n "`echo "$withval" | $GREP -o ":.*:"`"; then
> >
> > It seems that $GREP is undefined so the command "-o" is attempted.
> > Changing "$GREP" to "grep" works for me.
>
> GREP should be defined as a side effect of AC_PROG_EGREP.
> Please check if adding AC_PROG_GREP before AC_PROG_EGREP would fix your problem.

I made this change:

[[[
Index: configure.ac
===================================================================
--- configure.ac (revision 35054)
+++ configure.ac (working copy)
@@ -38,6 +38,7 @@
 AC_CANONICAL_TARGET

 # Look for an extended grep
+AC_PROG_GREP
 AC_PROG_EGREP

 AC_PROG_LN_S
]]]

and the result was:

[[[
$ ./autogen.sh
configure.ac:41: error: possibly undefined macro: AC_PROG_GREP
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
[...]
[...]/configure --prefix=/home/julianfoad/usr/local \
                --enable-maintainer-mode --disable-mod-activation \
                --with-ssl --without-serf --without-javahl \
                --with-sqlite=/home/julianfoad
[...]/configure: line 3271: AC_PROG_GREP: command not found
[...]/configure: line 21758: -o: command not found
[...]
]]]

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1009024
Received on 2009-01-07 02:26:03 CET

This is an archived mail posted to the Subversion Dev mailing list.