[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: packing race condition

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 6 Jan 2009 17:50:33 +0200 (Jerusalem Standard Time)

Hyrum K. Wright wrote on Tue, 6 Jan 2009 at 09:08 -0600:
> Daniel Shahaf wrote:
> > > > > Added the use of the write lock in r35031.
> > ...
> > > Do you need acquire_fs_mutex()?
> >
> > Ping? From reading fs-loader.c it seems to me that acquire_fs_mutex()
> > is only needed when common_pool is used. But svn_fs_pack() doesn't use
> > common_pool. Hence my question.
> >
> > (i.e., I'm not saying it's wrong the way it is; I'm only saying that I don't
> > see why *not* acquiring that mutex would be wrong.)
>
> I'm not sure. I simply emulated what I saw for upgrade. It sounds like you
> know more about this than I do. :)
>

I read the code (and the patch) and had a question. Don't call me an
expert just because of that. :-)

> -Hyrum
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1007750
Received on 2009-01-06 18:20:25 CET

This is an archived mail posted to the Subversion Dev mailing list.