Re: [PATCH] Re: svn commit: r35033 - in trunk/subversion: include libsvn_fs libsvn_fs_base libsvn_fs_fs libsvn_repos svnadmin tests/libsvn_fs_fs

>> Gettext is broken on line 1135 :
>>> + _("Packing shard %" APR_INT64_T_FMT "..."),
>>
>> You cannot use the *_FMT macros directly in a format, as it is missed by
>> the gettext string extractor.
>
> Is this the right way to fix this kind of problem?

I would say yes.

> - SVN_ERR(svn_cmdline_printf(pool,
> - _("Packing shard %" APR_INT64_T_FMT "..."),
> - shard));
> + {
> + const char *shardstr = apr_psprintf(pool, "%" APR_INT64_T_FMT,
> shard);
> + SVN_ERR(svn_cmdline_printf(pool, _("Packing shard %s..."),
> shardstr));
> + }
> break;
>
> case svn_fs_pack_notify_end:

-- 
Fabien.
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1007786