RE: [PATCH] unlock gnome-keyring

Bert Huijben wrote:

> Thanks for looking into this.

I am attaching the patch, which "removes cmdline prompt from library function". I shall commit this patch tomorrow if there is no changes required.

[[[
Follow up r34977.

Remove cmdline prompt added to a library function.

* subversion/libsvn_subr/auth.c
  (): Include svn_cmdline.h
  (svn_auth_get_platform_specific_provider): Change parameters passed to GNOME
   Keyring provider function.

* subversion/libsvn_subr/prompt.c
  (svn_cmdline_auth_unlock_prompt): New function to prompt for unlocking GNOME
   Keyring.

* subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
  (unlock_prompt_provider_baton_t): New baton.
  (get_default_keyring_name): New function to return default keyring's name.
  (check_keyring_is_locked): New function to check whether a keyring is locked.
  (gnome_keyring_unlock_keyring): Modified to unlock the provided keyring with
   a password supplied.
  (gnome_keyring_password_get, gnome_keyring_password_set): Get default
   keyring name with the new function.
  (gnome_keyring_simple_first_creds, gnome_keyring_simple_save_creds): Check
   if the keyring is locked and throw a prompt in order to get the password
   and unlock it.
  (svn_auth_get_gnome_keyring_simple_provider): Change signature in order to
   accept a prompt function. Since this API was added for 1.6, the name
   remains the same.

* subversion/include/svn_cmdline.h
  (svn_cmdline_auth_unlock_prompt): New function signature added.

* subversion/include/svn_auth.h
  (svn_auth_unlock_prompt_func_t): New callback.
  (svn_auth_unlock_provider_func_t): New function type returning GNOME Keyring
   authentication provider.
  (svn_auth_get_gnome_keyring_simple_provider): Change signature.
]]]

Thank You.

--
Senthil Kumaran S
http://www.stylesen.org/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1007590