[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: packing race condition

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 5 Jan 2009 21:05:40 +0200 (Jerusalem Standard Time)

Hyrum K. Wright wrote on Mon, 5 Jan 2009 at 13:00 -0600:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Daniel Shahaf wrote:
> > Hyrum K. Wright wrote on Mon, 5 Jan 2009 at 10:15 -0600:
> > Added the use of the write lock in r35031. Comments welcome.
> >
> >
> >> r35031 uses acquire_fs_mutex() and doesn't use svn_fs_fs__with_write_lock().
> >> Now, maybe it's a stupid question, but shouldn't it be the other way around?
>
> It uses both. Check out svn_fs_fs__pack() in fs_fs.c.
>

Sorry, didn't read carefully enough. Do you need acquire_fs_mutex(),
though?

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1005887
Received on 2009-01-05 20:08:00 CET

This is an archived mail posted to the Subversion Dev mailing list.