Re: svn commit: r34951 - trunk/subversion/libsvn_fs_fs

Not sure, but I'm guessing this affects BDB, too. Will look into it today.

Hyrum K. Wright wrote:
> Author: hwright
> Date: Fri Dec 26 15:15:59 2008
> New Revision: 34951
>
> Log:
> Only add representations to the rep-cache which are in the revision being
> committed. The issue here is that nodes which have just property mods may
> have data reps which are older than the format 4 filesystem, and thus only
> have md5 checksums. Attempting to add these nodes to the rep cache results
> in errors. This also has the happy side effect of not attempting to add
> nodes which do have the sha1 checksum, but which are already in the cache.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (write_final_rev): Only put a node in the rep cache if it is part of the
> current revision.
>
> Modified:
> trunk/subversion/libsvn_fs_fs/fs_fs.c
>
> Modified: trunk/subversion/libsvn_fs_fs/fs_fs.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/fs_fs.c?pathrev=34951&r1=34950&r2=34951
> ==============================================================================
> --- trunk/subversion/libsvn_fs_fs/fs_fs.c Fri Dec 26 15:06:11 2008 (r34950)
> +++ trunk/subversion/libsvn_fs_fs/fs_fs.c Fri Dec 26 15:15:59 2008 (r34951)
> @@ -5205,7 +5205,8 @@ write_final_rev(const svn_fs_id_t **new_
>
> /* Save the data representation's hash in the rep cache. */
> if (ffd->format >= SVN_FS_FS__MIN_REP_SHARING_FORMAT
> - && noderev->data_rep && noderev->kind == svn_node_file)
> + && noderev->data_rep && noderev->kind == svn_node_file
> + && noderev->data_rep->revision == rev)
> SVN_ERR(svn_fs_fs__set_rep_reference(fs, noderev->data_rep, FALSE, pool));
>
> /* Return our ID that references the revision file. */
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=495&dsMessageId=993433

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1005506