[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34967 - trunk/subversion/svn

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 30 Dec 2008 20:12:18 +0200 (Jerusalem Standard Time)

Arfrever Frehtes Taifersar Arahesis wrote on Tue, 30 Dec 2008 at 19:04 +0100:
> 2008-12-30 00:25:50 Daniel Shahaf napisaƂ(a):
> > > /* Update the options in the config */
> > > + for (i = 0; i < opt_state.config_options->nelts; i++)
> > > + {
> > > + config_option_t *config_option = APR_ARRAY_IDX(opt_state.config_options,
> > > + i, config_option_t *);
> > > + if (strcmp(config_option->file, "config") == 0)
> > > + {
> > > + svn_config_set(cfg_config, config_option->section,
> > > + config_option->option, config_option->value);
> > > + }
> > > + else if(strcmp(config_option->file, "servers") == 0)
> > > + {
> > > + svn_config_set(cfg_servers, config_option->section,
> > > + config_option->option, config_option->value);
> > > + }
> >
> > else
> > {
> > /* print a warning */
> > }
> >
> > ?
> >
> > > + }
> > > +
>
> I implemented the majority of these suggestions in r34975.
>
>

Thanks. Looks good. I see you didn't implement the last one (quoted
here), any particular reason why?

Thanks,

Daniel

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=996140
Received on 2008-12-30 20:12:23 CET

This is an archived mail posted to the Subversion Dev mailing list.