Re: canonicalized path hits assertion

On Mon, Dec 29, 2008 at 02:48:12PM +0100, Stefan Kueng wrote:
> Hi,
>
> Using an svn client built from trunk, trying to access a repository on a
> Windows network share
>
> $ svn list file://SERVER/svn/TestRepo
>
> will hit the assertion
> assert(svn_path_is_canonical());
> since svn_path_is_canonical() thinks that url is not canonical.

That check must be wrong, so. I'd like to fix this, but have
no access to Windows. Can you fix it?

On Unix, this fails with:

$ svn list file://SERVER/svn/TestRepo
subversion/libsvn_ra_local/ra_plugin.c:454: (apr_err=170000)
svn: Unable to open an ra_local session to URL
subversion/libsvn_ra_local/split_url.c:123: (apr_err=170000)
svn: Local URL 'file://server/svn/TestRepo' contains unsupported hostname

From reading the code, that failure is what we expect to happen.

> If I build the client in release mode with the assertions disabled, the
> list command works as it should. But the many, many assertions in debug
> mode are really annoying.

Then please convert all remaining asserts to either SVN_ERR_ASSERT_NO_RETURN
(for functions which do not return svn_error_t *, see r34334)
or SVN_ERR_ASSERT (for functions which return svn_error_t *).

After that your client can intercept all those errors.

Stefan

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=995121
Received on 2008-12-29 16:47:27 CET