[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svncopy.pl: option --file

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 26 Dec 2008 14:53:22 +0200 (Jerusalem Standard Time)

dario.borreguero_at_gmail.com wrote on Fri, 12 Dec 2008 at 03:47 -0800:
> Hi,
>
> I'm not sure if this should be a bug. I'll explain it below:
>
> I've started to use 'svncopy.pl' script and I found that if I try to
> add comments from a file, as I did with 'svn copy' subcommmand. It
> doesn't work.
>
> I returns the error message: Subcommand 'checkout' doesn't accept '-F
> [--file] PAR' option.
>

Then don't pass -F to 'svn checkout'. (And "PAR" isn't part of our
output, where did it come from?)

> I wonder why it tries to insert that file as an option for all the svn
> subcommand that are used within svncopy.pl script.
>
> I've looked into the code and I finally decided to change the line 95
> after checking that 'svn copy -m "Message" --file messages.txt'
> ignores the -m option and uses the file for comments.
>

No. If you specify the log message using both -m and -F, you get
*undefined behaviour*. Don't do this.

> Therefore,
>
> [95] "file|F=s" => sub { push(@svn_options, "--file", $_[1]) },
>
> to
>
> [95] "file|F=s" => sub { open FILE, $_[1]; my @content = <FILE>;
> $message = join("\n", @content); close FILE; },
>
> Before assuming that my change is correct or it shouldn't be done.
> I wonder if the option --file PAR is used with another intention than
> to use it as commit comment??
>

Yes, by 'svn propset' at least.

> I hope this helps,
>
> Dario.
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=983363
>

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=992913
Received on 2008-12-26 14:18:44 CET

This is an archived mail posted to the Subversion Dev mailing list.