[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34914 - branches/http-protocol-v2/subversion/libsvn_ra_serf

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: Thu, 25 Dec 2008 02:17:29 -0800

> > @@ -520,6 +522,14 @@ svn_ra_serf__get_latest_revnum(svn_ra_se
> > const char *relative_url, *basecoll_url;
> > svn_ra_serf__session_t *session = ra_session->priv;
> >
> > + /* Using HTTP protocol v2; already got it in the initial OPTIONS
> > response. */
> > + if (SVN_IS_VALID_REVNUM(session->youngest_rev))
> > + {
> > + *latest_revnum = session->youngest_rev;
> > + return SVN_NO_ERROR;
> > + }
> > +
> > + /* Fall back to old-fashioned way of getting it. */

Hmm, so won't this return incorrect (old) results if a commit
occurs between open and get_latest_revnuM? You could argue that
since svn_client treats ra connections as cheap and disposable
that's not a problem, but they're not necessarily cheap
(svn+ssh), and some clients may not be so cavalier...

This especially hurts a client that opens an RA connection and
then calls get_latest_revnum periodically, looking for a change.

-- 
Eric Gillespie <*> epg_at_pretzelnet.org
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=992182
Received on 2008-12-25 11:18:49 CET

This is an archived mail posted to the Subversion Dev mailing list.