Test suite failure on Windows - EOL style of stdout [was: svn trunk r34895: FAIL (win32-xp VS2005)]

buildbot_at_mobsol.be wrote:
> Full details are available at:
> http://www.mobsol.be/buildbot/win32-xp%2520VS2005/builds/1508
[...]

On Windows, the test suite's parsing of output from commands has broken
recently. This is shown by build-bot failures such as
<http://www.mobsol.be/buildbot/win32-xp%2520VS2005/builds/1505> at
r34888. The previous build-bot build of 'trunk' was successful:
<http://www.mobsol.be/buildbot/win32-xp%2520VS2005/builds/1503> at
r34827.

I think this may be due to the change to use the "subprocess" module on
Python >= 2.4, which was done in r34863. (The only other change to the
test suite in the range r34827:34888 was to depth_tests.py in r34875.)

The symptom: Lines of output from Subversion commands are displayed and
parsed as having an extra line-ending character of some kind. The
display doesn't necessarily matter, but the parsing does. Here is a
snippet of the test suite's diagnositc output:

[[[
START: getopt_tests.py
CMD: svnadmin.exe create "svn-test-work\local_tmp\repos" --bdb-txn-nosync "--fs-type=fsfs" <TIME = 0.296000>
CMD: svn.exe import -m "Log message for revision 1." "svn-test-work\local_tmp\greekfiles" "file:///M%3A/svn-auto-test/fsfs/subversion/tests/cmdline/svn-test-work/local_tmp/repos" --config-dir "M:\svn-auto-test\fsfs\subversion\tests\cmdline\svn-test-work\local_tmp\config" --password rayjandom --no-auth-cache --username jrandom <TIME = 0.672000>
Adding svn-test-work\local_tmp\greekfiles\A

Adding svn-test-work\local_tmp\greekfiles\A\B

Adding svn-test-work\local_tmp\greekfiles\A\B\lambda

Adding svn-test-work\local_tmp\greekfiles\A\B\E

Adding svn-test-work\local_tmp\greekfiles\A\B\E\alpha

Adding svn-test-work\local_tmp\greekfiles\A\B\E\beta

Adding svn-test-work\local_tmp\greekfiles\A\B\F

[...]

Couldn't find node 'A
' in expected output tree
 * Node name: A

    Path: svn-test-work\local_tmp\greekfiles\A

    Contents: None
    Properties: {}
    Attributes: {'verb': 'Adding'}
    Children: None (node is probably a file)
Unequal at node greekfiles
Unequal at node local_tmp
Unequal at node svn-test-work
ERROR: output of import command is unexpected.
EXPECTED OUTPUT TREE:
ROOT
  +-- svn-test-work
        +-- local_tmp
              +-- greekfiles
                    |-- A
                    | |-- B
                    | | |-- E
                    | | | |-- alpha
                    | | | +-- beta
                    | | |-- F
[...]
ACTUAL OUTPUT TREE:
ROOT
  +-- svn-test-work
        +-- local_tmp
              +-- greekfiles
                    |-- A
                    | |-- B
                    | | |-- E
                    | | | |-- alpha

                    | | | +-- beta

                    | | |-- E

                    | | |-- F

[...]
]]]

Can anyone on Windows confirm whether r34863 caused the problem? And find a fix?

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=990731
Received on 2008-12-23 15:58:19 CET