Fwd: [PATCH] Fix a ruby test failure

To the list this time. Doh.

---------- Forwarded message ----------
From: Joe Swatosh <joe.swatosh_at_gmail.com>
Date: Thu, Dec 18, 2008 at 9:06 PM
Subject: Re: [PATCH] Fix a ruby test failure
To: "Hyrum K. Wright" <hyrum_wright_at_mail.utexas.edu>

Hi Hyrum,

On Thu, Dec 18, 2008 at 12:40 PM, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> Kou, Joe,
> This fixes a ruby test failure on trunk, some variation thereof fixes the
> failure on 1.5.x. My ruby-test-swig-fu is pretty weak, so I'm posting here
> before committing. If either of you could look at it, that'd be great.
>
> -Hyrum
>
> [[[
> * subversion/bindings/swig/ruby/test/test_wc.rb
> (test_relocate): Fix a ruby test expectation.
> ]]]
>
> Index: subversion/bindings/swig/ruby/test/test_wc.rb
> ===================================================================
> --- subversion/bindings/swig/ruby/test/test_wc.rb (revision 34821)
> +++ subversion/bindings/swig/ruby/test/test_wc.rb (working copy)
> @@ -995,10 +995,14 @@
> assert_equal([
> [@fs.uuid, dir2_uri, nil],
> [@fs.uuid, dir2_uri, dir2_uri],
> - [nil, "#{dir2_uri}/#{dir1}", dir2_uri],
> - [nil, "#{dir2_uri}/#{dir1}/#{file1}", dir2_uri],
> - [nil, "#{dir2_uri}/#{dir2}", dir2_uri],
> - [nil, "#{dir2_uri}/#{dir2}/#{file2}", dir2_uri],
> + [@fs.uuid, "#{dir2_uri}/#{dir1}", nil],
> + [@fs.uuid, "#{dir2_uri}/#{dir1}", dir2_uri],
> + [@fs.uuid, "#{dir2_uri}/#{dir1}/#{file1}", nil],
> + [@fs.uuid, "#{dir2_uri}/#{dir1}/#{file1}", dir2_uri],
> + [@fs.uuid, "#{dir2_uri}/#{dir2}", nil],
> + [@fs.uuid, "#{dir2_uri}/#{dir2}", dir2_uri],
> + [@fs.uuid, "#{dir2_uri}/#{dir2}/#{file2}", nil],
> + [@fs.uuid, "#{dir2_uri}/#{dir2}/#{file2}", dir2_uri],
> ],
> values)
> assert(dir2_uri, access.entry(@wc_path).url)
>
>

I've been trying to figure out when that test started failing and why
the validate notification is now called so many more times than it
used to be. I can only work on this for a few hours a week, so I
don't know when I'll have answers to those questions. Personally, I
prefer to include more info about why the test expectations need to
change in the commit, but defer to your best judgement wrt committing
this patch.

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=987198