[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] unlock gnome-keyring

From: Mark Phippard <mphippard_at_collab.net>
Date: Wed, 17 Dec 2008 08:29:38 -0500

2008/12/15 Mark Phippard <markphip_at_gmail.com>:
> On Sun, Dec 14, 2008 at 7:32 PM, Arfrever Frehtes Taifersar Arahesis
> <Arfrever.FTA_at_gmail.com> wrote:
>> 2008-12-12 06:33 Alexander Thomas <alexander_at_collab.net> napisaƂ(a):
>>> Here is a patch which try to address a Subversion issues with gnome
>>> keyring support. Present implementation of gnome-keyring fails to access
>>> a locked keyring and if there is no X present.
>>> This patch, try to unlock the keyring by prompting the user for keyring
>>> password only if the default keyring is locked.
>> Could you write steps to reproduce "a locked keyring"?
> 1) Turn on computer
> No more steps. A keyring is locked until you unlock it. Since
> gnome-keyring only provides a GUI for this operation if you are
> working via an SSH terminal to a Linux system (without X) then there
> is no way to use an unlock your keyring without this patch.
> Without this patch the feature was useless except for users that are
> running Linux on their local graphical workstation. Even those users
> were not able to use the feature if they also use SSH to work on
> remote systems.
> With this patch, you just need to do this when you login to your SSH session:
> $ export `gnome-keyring-daemon`
> This starts the keyring and exports the environment variables used by
> the feature. SVN then has the code to detect your keyring is locked
> and prompts you to unlock it so that it can retrieve your passwords
> etc.

Does anyone have any feedback for Alex on this? Should I just ask
Senthil to commit it as is?

We need this functionality in SVN 1.6. The gnome-keyring feature is
only useful in one very specific situation without it. With this
patch, the gnome-keyring feature works very well and can be used to
store passwords securely even when there is no X environment

I'd rather not have to maintain a special 1.6 branch to hold this code.

Mark Phippard
Received on 2008-12-17 14:30:05 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.