[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Prune dead code from svn_wc_props_modified_p()

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 17 Dec 2008 02:10:02 -0800

On Mon, Dec 15, 2008 at 10:52, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
>...
>>> This patch seems to be pretty straightforward, but since it touches code used to
>>> interact with older WC formats, and I don't have a very good way of testing that
>>> code, I'm posting it here for review before committing.

It looks good. I have one nit, and then would suggest posting a copy
of the patch with whitespace-ignored. Then the changes will be even
easier to review.

Tho, really: I'd say go ahead and commit it, too. Like I say, it looks
good... the patch-post would just make another double-verification a
little bit easier.

>...
> + *modified_p = !(local_propchanges->nelts == 0);

Making life difficult for yourself?

  *modified_p = local_propchanges->nelts > 0;

Cheers,
-g

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=985624
Received on 2008-12-17 11:10:36 CET

This is an archived mail posted to the Subversion Dev mailing list.