[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Prune dead code from svn_wc_props_modified_p()

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Mon, 15 Dec 2008 12:38:56 -0600

Hyrum K. Wright wrote:
> This patch seems to be pretty straightforward, but since it touches code used to
> interact with older WC formats, and I don't have a very good way of testing that
> code, I'm posting it here for review before committing.
>
> (Let's hope tigris doesn't munge the attachment this time...)

This time attempting without signing the mail.

> [[[
> Simplify a function by removing code for never-used functionality.
>
> * subversion/libsvn_wc/props.c
> (svn_wc_props_modified_p): Remove large swaths of code made non-callable
> by a complete lack of desire for a list of the actual properties
> modified.
> ]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984605

Hyrum K. Wright wrote:
> This patch seems to be pretty straightforward, but since it touches code used to
> interact with older WC formats, and I don't have a very good way of testing that
> code, I'm posting it here for review before committing.
>
> (Let's hope tigris doesn't munge the attachment this time...)

This time attempting without signing the mail.

> [[[
> Simplify a function by removing code for never-used functionality.
>
> * subversion/libsvn_wc/props.c
> (svn_wc_props_modified_p): Remove large swaths of code made non-callable
> by a complete lack of desire for a list of the actual properties
> modified.
> ]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984605
Received on 2008-12-15 19:39:14 CET

This is an archived mail posted to the Subversion Dev mailing list.