[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Should svn_fs_fs__noderev_same_rep_key() accept NULL representation_t::uniquifier?

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Mon, 15 Dec 2008 11:50:11 -0600

David Glasser wrote:
> On Mon, Dec 15, 2008 at 7:06 AM, Julian Foad <julianfoad_at_btopenworld.com> wrote:
>> On Mon, 2008-12-15 at 08:49 -0600, Hyrum K. Wright wrote:
>>> Kouhei Sutou wrote:
>>>> Hi,
>>>>
>>>> I don't know about svn_fs_fs__noderev_same_rep_key() but it
>>>> causes "Segmentation fault" if a->uniquifier or
>>>> b->uniquifier is NULL. Should it accepts NULL or not?
>>> Yes. When reading pre-format-4 versions of the file system, the uniquifier will
>>> be NULL, so we should account for this possibility.
>> Can you make the doc string for the "uniquifier" field indicate that,
>> then, please? Presently it doesn't indicate that the field may be null.
>
> I also think you still haven't updated the documentation to note that
> the "node ID" counter in the transaction is now also used to feed the
> uniqifier. (1.6 release blocker: you can't redefine what the
> repository format means without updating the structure document.)

Yeah. It's on my internal TODO, I plan on doing it during the next day or so.
(As well as the uniquifier docs Julian mentioned above.)

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984585

Received on 2008-12-15 18:50:32 CET

This is an archived mail posted to the Subversion Dev mailing list.