[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34708 - in trunk/subversion/bindings/swig/ruby: svn test

From: Arfrever Frehtes Taifersar Arahesis <Arfrever.FTA_at_GMail.Com>
Date: Mon, 15 Dec 2008 12:32:35 +0100

2008-12-15 06:41 Joe Swatosh <joe.swatosh_at_gmail.com> napisaƂ(a):
> Author: joeswatosh
> Date: Sun Dec 14 21:41:26 2008
> New Revision: 34708
>
> Log:
> Follow on to r33730 "Merge the fs-rep-sharing branch to trunk."
>
> This merge exposed several bugs in the management of pool lifetimes in the
> bindings. So manage pool lifetimes better. Or at least try to.
>
> There are 3 errors and 1 failure. Two of the errors and the failure have to
> do with changes to authentication. The last error has to do with using time
> to specify a revision.
>
> * subversion/bindings/swig/ruby/svn/info.rb
> (Svn::Info#teardown): Close @repos before nilling it.
>
> * subversion/bindings/swig/ruby/svn/ra.rb
> (Svn::Ra::Session.open): Create and assign a pool to forward to
> Svn::Ra.open2, assign it to a session member variable. Return the session
> object as before if no block given, yield the session and ensure it is
> closed if a block is given.
> (Svn::Ra::Session#close): Destroy the pool.
>
> * subversion/bindings/swig/ruby/svn/client.rb
> (Svn::Client::Context#initialize): Create and assign a pool and assign it to
> a member variable.
> (Svn::Client::Context#close): Destroy the pool.
> (Svn::Client::Context#commit, Svn::Client::Context#open_ra_session,
> Svn::Client::Context#ls): Use the pool.
>
> * subversion/bindings/swig/ruby/test/util.rb
> (SvnTestUtil#setup_repository): Remember the repo we create instead of
> opening it again.
> (SvnTestUtil#make_context): Return the context object as before if no block
> given, yield the context and ensure it is closed if a block is given.
>
> * subversion/bindings/swig/ruby/test/windows_util.rb
> (SvnTestUtil::Windows::Svnserve#setup_svnserve): Add libapriconv.dll,
> sqlite3.dll, libdb44.dll, and libdb44d.dll to the targets needed.

Berkeley DB should be optional.
Other versions of Berkeley DB also should be supported.

> (SvnTestUtil::Windows::SetupEnvironment
> #add_depended_dll_path_to_dll_wrapper_util): Add the bin directory for
> SQLite to the list of wrapped paths.
>
> * subversion/bindings/swig/ruby/test/test_client.rb
> (SvnClientTest): Use the block version of make_context throughout the tests.
>
> * subversion/bindings/swig/ruby/test/test_repos.rb
> (SvnClientTest): Use the block version of make_context throughout the tests.
> (SvnClientTest#test_session): Rename the context variables used to store the
> results of make_context so we can have multiple contexts "live" at the
> same time and ensure they are each closed.
>
> * subversion/bindings/swig/ruby/test/test_delta.rb
> (SvnDeltaTest): Use the block version of make_context throughout the tests,
> plus some reorganization to move locals out of blocks.
>
> * subversion/bindings/swig/ruby/test/test_info.rb
> (SvnInfoTest): Use the block version of make_context throughout the tests,
> plus some reorganization to move locals out of blocks.
>
> * subversion/bindings/swig/ruby/test/test_fs.rb
> (SvnFsTest): Use the block version of make_context throughout the tests,
> plus some reorganization to move locals out of blocks.
>
> * subversion/bindings/swig/ruby/test/test_wc.rb
> (SvnWcTest): Use the block versions of make_context and
> Svn::Ra::Session.open throughout the tests.
>
> * subversion/bindings/swig/ruby/test/test_ra.rb
> (SvnRaTest): Use the block versions of make_context and
> Svn::Ra::Session.open throughout the tests, plus some reorganization to
> move locals out of blocks.

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984380
Received on 2008-12-15 12:33:07 CET

This is an archived mail posted to the Subversion Dev mailing list.