Re: SQLite and the Ruby bindings tests on Windows

Hi kou,

On Wed, Dec 10, 2008 at 4:16 AM, Kouhei Sutou <kou_at_cozmixng.org> wrote:
> Hi,
>
> In <ae6cb1100812082230u777205e8l60db5e0ee161732d_at_mail.gmail.com>
> "SQLite and the Ruby bindings tests on Windows" on Mon, 8 Dec 2008 22:30:10 -0800,
> Joe Swatosh <joe.swatosh_at_gmail.com> wrote:
>
>> Hi,

>
> What about adding Svn::Client::Context#close and
> Svn::Client::Context#initialize accepts a block?
>
> pseudo code:
> class Svn::Client::Context
> def initialize(...)
> ...
> return unless block_given?
> begin
> yield(self)
> ensure
> close
> end
> end
>
> def close
> @pool.destroy
> end
> end
>
> But I'm not sure that 'close' is a good name for that...
>

Based on the above idea, I committed r34708. Instead of Context#initialize
taking a block I modified SvnTestUtil#make_context to take a block. I think
that worked better for updating the tests, but I'd like to see the
Context#initialize take a block someday. I'm getting 3 errors and a failure,
but they seemed unrelated to the SQLite/pool problems I was having. For the
record here are the errors and failures:

  1) Failure:
test_add_providers(SvnClientTest)
[D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2130]:
Exception raised:
Class: <RuntimeError>
Message: <"'svn_auth_get_windows_ssl_server_trust_provider' is not
available on this platform.">
---Backtrace---
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_auth_get_windows_ssl_server_trust_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`auth_get_windows_ssl_server_trust_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/core.rb:223:in
`add_windows_ssl_server_trust_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2135:in
`test_add_providers'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2130:in
`test_add_providers'
---------------

  2) Error:
test_keychain_simple_provider(SvnClientTest):
RuntimeError: 'svn_auth_get_keychain_simple_provider' is not available
on this platform.
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_auth_get_keychain_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`auth_get_keychain_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/core.rb:201:in
`add_keychain_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2042:in
`send'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2042:in
`assert_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2069:in
`test_keychain_simple_provider'

  3) Error:
test_set_revision_by_date(SvnClientTest):
Svn::Error::ClientUnrelatedResources:
D:\svn\src-trunk\subversion\libsvn_client\ra.c:695:
Svn::Error::ClientUnrelatedResources: Unable to find repository
location for 'file:///D:/SVN/src-trunk/subversion/bindings/swig/ruby/repos/hello.txt'
in revision 0
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_client_cat2'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in `cat2'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/client.rb:399:in `cat'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2342:in
`test_set_revision_by_date'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/util.rb:181:in
`make_context'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2331:in
`test_set_revision_by_date'

  4) Error:
test_windows_simple_provider(SvnClientTest):
RuntimeError: 'svn_auth_get_windows_simple_provider' is not available
on this platform.
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`svn_auth_get_windows_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
`auth_get_windows_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/svn/core.rb:195:in
`add_windows_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2042:in
`send'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2042:in
`assert_simple_provider'
D:/SVN/src-trunk/subversion/bindings/swig/ruby/test/test_client.rb:2063:in
`test_windows_simple_provider'

I think the provider tests are failing and erring because I haven't kept up
with the changes that Jeremy Whitlock made around authentication in the SWIG
bindings. Now that I'm able to run the tests again, I'll start looking into
those.

The last error is from the test you added for Takeuchi Yusuke. It looks like
it should pass to me, but I didn't want to delay r34708 any longer.

--
Joe
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=984271