[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix warning of signedness in fs_skels.c

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Thu, 11 Dec 2008 06:53:39 -0800

Senthil Kumaran S wrote:
> Hi,
>
> I am attaching a patch which fixes the following warning in
> "subversion/libsvn_fs_base/util/fs_skels.c".
>
> <snip>
> ../subversion/libsvn_fs_base/util/fs_skels.c: In function
> 'svn_fs_base__parse_representation_skel':
> ../subversion/libsvn_fs_base/util/fs_skels.c:558: warning: pointer targets in
> passing argument 1 of 'svn_checksum__from_digest' differ in signedness
> ../subversion/libsvn_fs_base/util/fs_skels.c:566: warning: pointer targets in
> passing argument 1 of 'svn_checksum__from_digest' differ in signedness
> </snip>
>
> [[[
> Fix warning of signedness.
>
> * subversion/libsvn_fs_base/util/fs_skels.c
> (svn_fs_base__parse_representation_skel): Typecast 'const char' to
> 'const unsigned char' for checksum_skel->children->next->data.
>
> Patch by: stylesen
> ]]]

Looks good to me.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=982865

Received on 2008-12-11 15:53:59 CET

This is an archived mail posted to the Subversion Dev mailing list.