[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34648 - trunk/subversion/libsvn_wc

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 10 Dec 2008 15:09:54 -0800

Patch looks great! One metalevel style nit that I wanted to mention:

On Wed, Dec 10, 2008 at 09:25, Hyrum K. Wright <hyrum_at_hyrumwright.org> wrote:
> @@ -2965,13 +2961,12 @@ modified_props(svn_boolean_t *modified_p
> svn_prop_diffs(). */
> {
> apr_array_header_t *local_propchanges;
> - apr_hash_t *localprops = apr_hash_make(subpool);
> - apr_hash_t *baseprops = apr_hash_make(subpool);
> + apr_hash_t *localprops, *baseprops;

Personally, I prefer to do all declarations one per line. Obviously
not saying to change it here or that it should change. Just thought
I'd take the moment to bring it up. Having one per line makes it
easier to add/remove/alter initializers like above. I think it can
also be clearer to read the declaration. Sometimes the "*" symbols can
get lost in the midst.

I think we talked about this particular convention a while back, but
left it to personal preference. So I'm just stating mine in case you
see me undo those things :-)


Received on 2008-12-11 00:10:13 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.