[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Infinite re-prompts for user credentials

From: Ben Collins-Sussman <sussman_at_red-bean.com>
Date: Wed, 10 Dec 2008 08:47:17 -0600

Sorry for not understanding, but why would a user ever want to be
re-prompted forever? I've always thought the 3-retries behavior was
deliberate and friendly.

On Dec 10, 2008 5:52 AM, "Alexander Thomas" <alexander_at_collab.net> wrote:

Here is a patch which will re-prompts for user credentials infinite times.
I saw rapidSVN uses cranky way to get the infinite prompts, where they
set the retry_limit to a arbitrary large value. This patch can accept
a negative value for the retry_limit, to make it infinite. At present
if a value above zero is give for the retry_limit,
svn_auth_next_credentials() will re-prompt for user credentials up to
a maximum of retry_limits.

This is a behavioral change but I don;t think there exists any application
that sets negative value for retry_limit, So might be safe not to create new
versions of these changed functions.

[[[
A negative value to the retry_limit will re-prompt for user credentials
infinite times.

* subversion/libsvn_subr/ssl_client_cert_pw_providers.c
 (ssl_client_cert_pw_prompt_next_cred): Modified not to give up if a
  negative value is given as retry_limit.

* subversion/libsvn_subr/ssl_client_cert_providers.c
 (ssl_client_cert_prompt_next_cred): Modified not to give up if a
  negative value is given as retry_limit.

* subversion/libsvn_subr/username_providers.c
 (username_prompt_next_creds): Modified not to give up if a
  negative value is given as retry_limit.

* subversion/libsvn_subr/simple_providers.c
 (simple_prompt_next_creds): Modified not to give up if a
  negative value is given as retry_limit.

* subversion/include/svn_client.h
* subversion/include/svn_auth.h
 Fix doc to reflect above change.

Patch by: Alexander Thomas <alexander_at_collab.net>
]]]

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=982147

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=982265
Received on 2008-12-10 15:47:46 CET

This is an archived mail posted to the Subversion Dev mailing list.