Re: Problem with WC to URL copy in JavaHL 1.5.x

On Sat, Dec 6, 2008 at 2:49 PM, Hyrum K. Wright
<hyrum_wright_at_mail.utexas.edu> wrote:
> Mark Phippard wrote:
>> Just to follow-up, this problem still happens in trunk. I have
>> attached a patch to the JavaHL tests that causes the breakage. I also
>> looked into the NotifyInformation class and there is no way to fix
>> this problem in that class as the error occurs in a base class from
>> the JDK that it inherits from.
>>
>> I can commit the patch but it causes breakage. I thought it might be
>> easier to just give to someone that is willing to look into the
>> problem.
>
> The attached patch fixes the problem locally by setting the commit item path to
> the same value as the url. The result will be the url being passed as the path
> parameter to the notification callback. Do we do that for the other items in a
> wc-to-url copy, or are the notification paths some sort of relative path?

I am not sure if a URL is valid for PATH. Are there any other
notifications we send a URL back? I do not think there are any.
Could we suppress sending the notification when we do not have a PATH?

Without your patch, I was wondering how the test might vary if I
changed the peg revision. It is currently set to Revision.WORKING.
It seems like Revision.BASE could be a valid alternative. However,
when I make that change, the failure just changes to:

1) testCopy(org.tigris.subversion.javahl.BasicTests)org.tigris.subversion.javahl.ClientException:
A path under version control is needed for this operation
svn:

     : (apr_err=195000)
        at org.tigris.subversion.javahl.SVNClient.copy(Native Method)
        at org.tigris.subversion.javahl.SVNClientSynchronized.copy(SVNClientSynchronized.java:670)
        at org.tigris.subversion.javahl.BasicTests.testCopy(BasicTests.java:885)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
        at org.tigris.subversion.javahl.RunTests.main(RunTests.java:111)

The spaces are interesting.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=980586