I'd go ahead and commit the patch. I'll try to look at the problem in the next
couple of days.
-Hyrum
Mark Phippard wrote:
> Just to follow-up, this problem still happens in trunk. I have
> attached a patch to the JavaHL tests that causes the breakage. I also
> looked into the NotifyInformation class and there is no way to fix
> this problem in that class as the error occurs in a base class from
> the JDK that it inherits from.
>
> I can commit the patch but it causes breakage. I thought it might be
> easier to just give to someone that is willing to look into the
> problem.
>
> Mark
>
>
>
> On Wed, Dec 3, 2008 at 1:31 PM, Mark Phippard <markphip_at_gmail.com> wrote:
>> I know there are existing reports of problems doing command line copy
>> from WC to URL in 1.5. I do not think this issue is the same. First
>> off, the copy itself is succesful. However JavaHL gets an internal
>> error during the notifications process when the copy runs. It only
>> happens when using the option to make parents. This is the stack
>> trace we see from Subclipse:
>>
>> java.lang.IllegalArgumentException: null source at
>> java.util.EventObject.<init>(EventObject.java:38) at
>> org.tigris.subversion.javahl.NotifyInformation.<init>(NotifyInformation.java:120)
>> at org.tigris.subversion.javahl.SVNClient.copy(Native Method) at
>> org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.copy(AbstractJhlClientAdapter.java:676)
>> at org.tigris.subversion.subclipse.core.commands.BranchTagCommand.run(BranchTagCommand.java:99)
>> at org.tigris.subversion.subclipse.ui.operations.BranchTagOperation.execute(BranchTagOperation.java:70)
>> at org.tigris.subversion.subclipse.ui.operations.RepositoryProviderOperation.execute(RepositoryProviderOperation.java:71)
>> at org.tigris.subversion.subclipse.ui.operations.SVNOperation.run(SVNOperation.java:89)
>> at org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnableContext.java:144)
>> at org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.runInWorkspace(JobRunnableContext.java:72)
>> at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
>> at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)
>>
>> The error occurs whenever parent directories need to be created. The
>> parent directories are created and the copy succeeds, then the error.
>>
>> These are the values passed to NotifyInformation when the error occurs:
>>
>> path = null
>> action = 16
>> kind = 0
>> mimeType = null
>> lock = null
>> errMsg = null
>> contentState = 1
>> propState = 1
>> lockState = 1
>> revision = -1
>> changelistName = null
>> mergeRange = null
>>
>> My assumption is that this notification should either not be sent or
>> it should have a non-null value for path as that seems to be a
>> requirement for this class that has long been in the code.
>>
>> When the error does not occur (parent directories not created),
>> NotifyInformation is constructed 3 times. These are the values that
>> differ from above:
>>
>> 1st notification:
>>
>> path = working copy path
>> kind = 2
>>
>> 2nd notification:
>>
>> path = working copy path
>> action = 15
>> kind = 1
>> contentState = 5
>> propState = 2
>>
>> 3rd notification:
>>
>> path = working copy path
>> action = 19
>> kind = 1
>>
>> When parent directories must be created, the error occurs regardless
>> of whether copyAsChild is true or false.
>>
>> --
>> Thanks
>>
>> Mark Phippard
>> http://markphip.blogspot.com/
>>
>
>
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=979829
Received on 2008-12-04 22:24:11 CET