[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34537 - trunk/subversion/libsvn_fs_fs

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: Wed, 03 Dec 2008 12:25:12 +0000

Hyrum K. Wright wrote:
> Yeah, I felt the same way here, but I was hesitant to put a conditional in the
> middle of the inner loop like that, especially since it would only be true one
> time in 1000.

I'm wondering if you hesitated entirely for reasons of execution speed,
or for aesthetics of the code structure. If you're talking about the
"for (tmp_rev...)" loop which contains 4 non-trivial lines of high-level
code, speed won't be an issue because a simple conditional like "if
(tmp_rev == rev) { ... }" would add only about 2 or 3 machine
instructions of overhead to the hundreds or thousands that are already
there.

- Julian

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=978847
Received on 2008-12-03 13:25:57 CET

This is an archived mail posted to the Subversion Dev mailing list.