[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34510 - trunk/subversion/libsvn_fs_fs

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Tue, 02 Dec 2008 12:14:41 -0600

Julian Foad wrote:
> On Mon, 2008-12-01 at 10:43 -0800, hwright_at_tigris.org wrote:
>> Author: hwright
>> Date: Mon Dec 1 10:43:20 2008
>> New Revision: 34510
>>
>> Log:
>> * subversion/libsvn_fs_fs/caching.c
>> (svn_fs_fs__initialize_caches): Followup to r34502: Make the pack offset
>> cache use 8K pages.
>>
>> Suggested by: glasser
>>
>> Modified:
>> trunk/subversion/libsvn_fs_fs/caching.c
>>
>> Modified: trunk/subversion/libsvn_fs_fs/caching.c
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_fs_fs/caching.c?pathrev=34510&r1=34509&r2=34510
>> ==============================================================================
>> --- trunk/subversion/libsvn_fs_fs/caching.c Mon Dec 1 10:00:51 2008 (r34509)
>> +++ trunk/subversion/libsvn_fs_fs/caching.c Mon Dec 1 10:43:20 2008 (r34510)
>> @@ -273,7 +273,7 @@ svn_fs_fs__initialize_caches(svn_fs_t *f
>> else
>> SVN_ERR(svn_cache__create_inprocess(&(ffd->packed_offset_cache),
>> dup_pack_offset, sizeof(svn_revnum_t),
>> - 16, 1024, FALSE, fs->pool));
>> + 16, 512, FALSE, fs->pool));
>
> Please could you add a comment (such as glasser's email comment) to
> explain the magic of this number? :-)

If I explained the magic, it wouldn't be magic anymore, now would it?

r34527.

-Hyrum

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=728400

Received on 2008-12-02 19:15:09 CET

This is an archived mail posted to the Subversion Dev mailing list.