Philip Martin wrote:
> I'm seeing lots of regression test failures, typically:
>
..
> I can get rid of the line 274 failure by reordering the checks:
>
> Index: ../src/subversion/libsvn_subr/dirent_uri.c
> ===================================================================
> --- ../src/subversion/libsvn_subr/dirent_uri.c (revision 34142)
> +++ ../src/subversion/libsvn_subr/dirent_uri.c (working copy)
> @@ -271,7 +271,7 @@
> }
>
> /* Remove the trailing slash if necessary. */
> - if (*(dst - 1) == '/' && canon_segments > 0)
> + if (canon_segments > 0 && *(dst - 1) == '/')
> {
> dst --;
> }
>
> I don't know if it's right and it doesn't fix the other failures.
>
I've committed this change in r34232. The other valgrind warnings I
can't reproduce. Do you still see them with latest trunk?
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-25 23:24:33 CET