Re: svn commit: r34387 - in branches/tc_url_rev/subversion: include include/private libsvn_wc

rhuijben_at_tigris.org wrote:
> Author: rhuijben
> Date: Mon Nov 24 13:14:23 2008
> New Revision: 34387
>
> Log:
> On branch tc_url_rev:
> Add constructor function for svn_wc_conflict_version_t.
>
> Whether this function should be private or public is still under discussion.
> http://svn.haxx.se/dev/archive-2008-11/0905.shtml
> (This function should be equally public as svn_wc__conflict_version_dup)
>
> * subversion/include/private/svn_wc_private.h
> (svn_wc__conflict_version_create): New constructor for
> svn_wc_conflict_version_t.
> * subversion/include/svn_wc.h
> (svn_wc_conflict_version_t): Document users should use
> svn_wc__conflict_version_create to create instances.

Um, no, you didn't. :)
Adjusted the log according to this:

[[[
Modified: branches/tc_url_rev/subversion/include/svn_wc.h
URL:
http://svn.collab.net/viewvc/svn/branches/tc_url_rev/subversion/include/svn_wc.h?pathrev=34387&r1=34386&r2=34387
==============================================================================
--- branches/tc_url_rev/subversion/include/svn_wc.h Mon Nov 24 11:19:48
2008 (r34386)
+++ branches/tc_url_rev/subversion/include/svn_wc.h Mon Nov 24 13:14:23
2008 (r34387)
@@ -1210,8 +1210,8 @@ typedef struct svn_wc_conflict_version_t
   /* const char *content_cache_path; */
   /* const char *props_cache_path; */

- /* Remember to update svn_wc__conflict_version_dup()
- * in case you add fields to this struct. */
+ /* Remember to update svn_wc__conflict_version_create() and
+ * svn_wc__conflict_version_dup() in case you add fields to this struct. */
 } svn_wc_conflict_version_t;

Modified: branches/tc_url_rev/subversion/libsvn_wc/tree_conflicts.c
]]]

Added that missing comment, made ..._create and ..._dup public API in r34400.

Thanks!
~Neels