[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34213 - trunk/subversion/libsvn_fs_fs

From: Blair Zajac <blair_at_orcaware.com>
Date: Mon, 24 Nov 2008 12:37:23 -0800

Philip Martin wrote:
> Blair Zajac <blair_at_orcaware.com> writes:
>
>>>> + conflict = svn_stringbuf_create("", iterpool);
>>> Allocating conflict from iterpool causes fs-test 32 to fail:
>>>
>>> valgrind -q subversion/tests/libsvn_fs/.libs/lt-fs-test 32
>>> ==17969== Invalid read of size 1
>>> ==17969== at 0x4A1C7D1: strcmp (mc_replace_strmem.c:341)
>>> ==17969== by 0x40246E: test_commit_txn (fs-test.c:87)
>>> ==17969== by 0x412E2B: unordered_txn_dirprops (fs-test.c:4706)
>>> ==17969== by 0x4B2499A: do_test_num (svn_test_main.c:192)
>>> ==17969== by 0x4B25132: main (svn_test_main.c:395)
>>> ==17969== Address 0x8D59D28 is 0 bytes inside a block of size 8 free'd
>>> ==17969== at 0x4A1B46D: free (vg_replace_malloc.c:233)
>>> ==17969== by 0x50C978B: pool_clear_debug (apr_pools.c:1395)
>>> ==17969== by 0x50C989D: pool_destroy_debug (apr_pools.c:1457)
>>> ==17969== by 0x5AC3DD3: svn_fs_fs__commit_txn (tree.c:1739)
>>> ==17969== by 0x4C2B191: svn_fs_commit_txn (fs-loader.c:628)
>>> ==17969== by 0x402394: test_commit_txn (fs-test.c:67)
>>> ==17969== by 0x412E2B: unordered_txn_dirprops (fs-test.c:4706)
>>> ==17969== by 0x4B2499A: do_test_num (svn_test_main.c:192)
>>> ==17969== by 0x4B25132: main (svn_test_main.c:395)
>>>
>>> Would it work to create the conflict stringbuf in pool outside the
>>> looop? Or...
>> Hi Philip,
>>
>> Thanks. Is this a new error?
>
> Since r34213.
>
>> I ran the entire test suite with trunk
>> before I committed it and didn't get a core dump.
>
> You probably won't see it unless you enable APR pool debugging. I'm
> currently using the following patch:

Philip,

Looks like you committed this in r34376.

Thanks!
Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-24 21:37:43 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.