RE: svn commit: r34332 - in branches/tc_url_rev/subversion: include libsvn_wc

On Sun, 2008-11-23 at 11:23 +0100, Bert Huijben wrote:
> Why allocate a structure if all fields have their default value? I
> would have to check 4 variables instead of just 1 when I want to know
> if I can show a peg URL to a user from a conflict handler.

Unless we make the fields inside the structure mandatory, you now have
to check 5 variables (the struct pointer and the 4 inside it) instead of
4.

> * The svn_wc_conflict_description is not a tree conflicts only
> structure

Correct. I designed it intentionally to be an improvement that text and
property conflicts can use too, in future. That is partly why all fields
are optional.

> * If we would make it an inline structure it can't be copied and it
> can't be extended in later subversion releases without revving the
> entire conflict api.

Yes, I see. (To make it possible to extend it in future without revving
the entire conflicts API, we have to be careful about allocating and
duplicating and accessing it, and to keep the same type name. I have
commented on this issue in the branch-diff email.)

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-24 15:44:36 CET