[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34326 - in branches/tc_url_rev/subversion: include include/private libsvn_client libsvn_wc svn

From: Neels J Hofmeyr <neels_at_elego.de>
Date: Mon, 24 Nov 2008 02:39:34 +0100

Stefan Sperling wrote:
> On Sun, Nov 23, 2008 at 03:44:21AM +0100, Neels J Hofmeyr wrote:
>> Say, why is it necessary to
>>
>> 1. be able to set OLDER_ and THEIR_VERSION during
>> svn_wc_conflict_description_create_tree()?
>
...

> If you disagree, that's OK, I'm not too much in love with
> either solution. Both work, you just have to know what's
> going on.
>
>> 2. have them as pointers in the conflict description? I think this
>> introduces new errors that aren't necessary, like this one :P
>
> Take a look below at svn_wc__conflict_description_dup() from libsvn_wc/util.c
> ('//'-style comments added by me in this mail):
...

The way it turned out to be now is no less perfect than any other solution.
Let's stay with the current state. I like it after all.

~Neels

Received on 2008-11-24 02:40:07 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.