Re: svn commit: r34326 - in branches/tc_url_rev/subversion: include include/private libsvn_client libsvn_wc svn

On Sun, Nov 23, 2008 at 12:50:31PM +0000, Stefan Sperling wrote:
> On Sun, Nov 23, 2008 at 03:44:21AM +0100, Neels J Hofmeyr wrote:
> > I think having this as a pointer adds loads of ugly checking to the code
> > while yielding only tiny benefits. +1 for changing back to inlining the
> > svn_wc_version_t into the svn_wc_conflict_t struct.
>
> If you think the above inconsistency in the dup() function is the
> better alternative, that's fine with me, too.

As per http://svn.haxx.se/dev/archive-2008-11/0878.shtml
I'm now -1 on changing the members back to inline structs.
I'll audit my change for missing NULL checks instead.

Forcing ourselves into potentially having to rev API even for
small tweaks is a bad thing.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-23 14:11:31 CET