Re: svn commit: r34293 - branches/tc_url_rev/subversion/libsvn_wc

On Thu, Nov 20, 2008 at 08:00:35PM -0800, Greg Stein wrote:
> Woah... I just noticed what is going on here.
>
> Why are we not using skel's or the svn protocol structures? I
> seriously disagree with adding Yet Another Storage Format into our
> code. This is ridiculous.
>
> I'm not sure when this snuck into the code, but I'm a big -1 on another format.

FWIW, it got into the code when myself and sbutler were first
starting out with storing additional information in the entries
file. There was no mention whatsoever of skels in any related
documentation.

I'm sorry that we did not bend over backwards and looked into
server-side code hidden in subversion/libsvn_fs_base/util
while working in working copy code in subversion/libsvn_wc
to find out whether there was something there we could
use to store information in the entries file (a concept
private to libsvn_wc).

If you want that API to be used in general, put it into
public headers where people can actually see it.
Otherwise, ridiculous yerself :-P

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-21 11:38:23 CET