Ah. Interesting. Guess I missed that in the man page. Thanks!
On Thu, Nov 20, 2008 at 04:58, Arfrever Frehtes Taifersar Arahesis
<arfrever.fta_at_gmail.com> wrote:
> 2008/11/20 <gstein_at_tigris.org>:
>> Author: gstein
>> Date: Wed Nov 19 23:22:24 2008
>> New Revision: 34280
>>
>> Log:
>> Second attempt at adding more warning flags to maintainers' build. First
>> attempt was r34258 which broke the build for some (reverted in r34263).
>> This version will now test for the acceptance of some GCC flags (which
>> older GCC versions may not have
>
> FYI, these options are specific to Mac OS X.
> http://developer.apple.com/documentation/developertools/gcc-4.2.1/gcc/Warning-Options.html#index-Wextra_002dtokens-223
> http://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html
>
>> ) before deciding to use them.
>>
>> * configure.ac:
>> (CFLAGS): add some warning flags for maintainers. for a select few (only
>> present in newer GCCs), test for their existence first.
>>
>> Modified:
>> trunk/configure.ac
>>
>> Modified: trunk/configure.ac
>> URL: http://svn.collab.net/viewvc/svn/trunk/configure.ac?pathrev=34280&r1=34279&r2=34280
>> ==============================================================================
>> --- trunk/configure.ac Wed Nov 19 21:36:46 2008 (r34279)
>> +++ trunk/configure.ac Wed Nov 19 23:22:24 2008 (r34280)
>> @@ -703,6 +703,7 @@ AS_HELP_STRING([--enable-debug],
>> # the CFLAGS/CXXFLAGS munging.
>> ])
>>
>> +
>> AC_ARG_ENABLE(maintainer-mode,
>> AS_HELP_STRING([--enable-maintainer-mode],
>> [Turn on debugging and very strict compile-time warnings]),
>> @@ -713,8 +714,30 @@ AS_HELP_STRING([--enable-maintainer-mode
>> fi
>> enable_debugging=yes
>> if test "$GCC" = "yes"; then
>> - CFLAGS="$CFLAGS -Wpointer-arith -Wwrite-strings -Wshadow"
>> + AC_MSG_NOTICE([maintainer-mode: adding GCC warning flags])
>> + CFLAGS="$CFLAGS -Wpointer-arith -Wwrite-strings -Wshadow -ansi -std=c99 -Wall -Wformat=2 -Wunused -Waggregate-return -Wstrict-prototypes -Wold-style-definition -Wmissing-prototypes -Wmissing-declarations -Wno-multichar -Wredundant-decls -Wnested-externs -Wunreachable-code -Winline -Wno-long-long"
>> CXXFLAGS="$CXXFLAGS -Wpointer-arith -Wwrite-strings -Wshadow"
>> +
>> + dnl some additional flags that can be handy for an occasional review,
>> + dnl but throw too many warnings in svn code, of too little importance,
>> + dnl to keep these enabled. Remove the "dnl" to do a run with these
>> + dnl switches enabled.
>> + dnl CFLAGS="$CFLAGS -Wswitch-enum -Wswitch-default"
>> +
>> + CFLAGS_KEEP="$CFLAGS"
>> + AC_LANG_PUSH([C])
>> +
>> + CFLAGS="$CFLAGS_KEEP -Wextra-tokens"
>> + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [CFLAGS_KEEP="$CFLAGS"])
>> +
>> + CFLAGS="$CFLAGS_KEEP -Wnewline-eof"
>> + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [CFLAGS_KEEP="$CFLAGS"])
>> +
>> + CFLAGS="$CFLAGS_KEEP -Wshorten-64-to-32"
>> + AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [CFLAGS_KEEP="$CFLAGS"])
>> +
>> + AC_LANG_POP([C])
>> + CFLAGS="$CFLAGS_KEEP"
>> fi
>> fi
>> ])
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-20 16:05:07 CET