[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Problem with svn workdir over samba

From: Konstantin Ryabitsev <icon_at_fedoraproject.org>
Date: Tue, 18 Nov 2008 21:16:08 -0500

On Mon, Nov 17, 2008 at 4:08 PM, Konstantin Ryabitsev
<icon_at_fedoraproject.org> wrote:
> On Mon, Nov 17, 2008 at 3:45 PM, Alan Wood <alan.wood_at_clear.net.nz> wrote:
>> In libsvn_subr/io.c around line1843 there is code to force a non-win32 client to
>> rewind the directory after deleting an item when doing a recursive delete. For the
>> same reasons that this is taken out for windows build, it should also not be there for
>> samba file systems. Does anybody know why a unix system should require this
>> rewind?? I can't see why in the readdir_r() docs that the apr routines seem to call.
>> You could try removing this!
> Okay, I'll see if I can apply a patch to remove the rewind (and just
> act like a win32 client). Hopefully there won't be any side-effects.

I can confirm that removing the #ifndef for dir rewinding fixes the
problem. The question I have is whether this is likely to have
side-effects. If not, I will advise the Fedora packager to apply the
patch -- I'm sure he'll want a good reason, though.

Thanks for your help.


Konstantin Ryabitsev
Montréal, Québec
Received on 2008-11-19 03:17:16 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.