Re: Perl/Ruby bindings fail in trunk

Mark Phippard wrote:
> On Fri, Nov 14, 2008 at 10:04 AM, Mark Phippard <markphip_at_gmail.com> wrote:
>> On Thu, Nov 13, 2008 at 8:43 AM, Kouhei Sutou <kou_at_cozmixng.org> wrote:
>>> Hi,
>>>
>>> In <f16625f20811121745q6ef836f6w196068a04665ac45_at_mail.gmail.com>
>>> "Re: Perl/Ruby bindings fail in trunk" on Wed, 12 Nov 2008 18:45:22 -0700,
>>> "Jeremy Whitlock" <jcscoobyrs_at_gmail.com> wrote:
>>>
>>>>> All tests before that one passed on Linux. The segfault kills the test run,
>>>>> so I do not know if there will be more errors.
>>>> I can confirm this as well.
>>> It seems that r33975 misses NULL checks.
>> With this patch applied my segfault is fixed when running the Ruby
>> tests. Hyrum, if you see this could you look at this patch and
>> possibly commit it? It looks related to code you were working on and
>> no one else has committed it.
>>
>> After applying the patch, here are the results I get from the Ruby
>> tests (which do run to completion now):
>>
>> Loaded suite .
>> Started
>> .....................................EE.....................................................................................FF..............................................................F........F...............
>> Finished in 477.687061 seconds.
>>
>> 1) Error:
>> test_merge(SvnClientTest):
>> Svn::Error::WcFoundConflict:
>> subversion/libsvn_client/commit_util.c:341:
>> Svn::Error::WcFoundConflict: Aborting commit:
>> '/Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/wc-tmp/wc/trunk/sample.txt'
>> remains in conflict
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
>> `svn_client_commit4'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
>> `commit4'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/client.rb:156:in
>> `commit'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_client.rb:990:in
>> `assert_merge'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_client.rb:1013:in
>> `test_merge'
>>
>> 2) Error:
>> test_merge_peg(SvnClientTest):
>> Svn::Error::WcFoundConflict:
>> subversion/libsvn_client/commit_util.c:341:
>> Svn::Error::WcFoundConflict: Aborting commit:
>> '/Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/wc-tmp/wc/trunk/sample.txt'
>> remains in conflict
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
>> `svn_client_commit4'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/util.rb:86:in
>> `commit4'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/client.rb:156:in
>> `commit'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_client.rb:990:in
>> `assert_merge'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_client.rb:1019:in
>> `test_merge_peg'
>>
>> 3) Failure:
>> test_delta(SvnFsTest)
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_fs.rb:366:in
>> `test_delta'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/fs.rb:100:in
>> `transaction'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_fs.rb:361:in
>> `test_delta':
>> <Svn::Error::ChecksumMismatch> exception expected but none was thrown.
>>
>> 4) Failure:
>> test_delta_with_deprecated_api(SvnFsTest)
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_fs.rb:366:in
>> `test_delta'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/fs.rb:100:in
>> `transaction'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_fs.rb:361:in
>> `test_delta'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_fs.rb:373:in
>> `test_delta_with_deprecated_api':
>> <Svn::Error::ChecksumMismatch> exception expected but none was thrown.
>>
>> 5) Failure:
>> test_entry(SvnWcTest)
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:201:in
>> `test_entry'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/wc.rb:117:in
>> `_open'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/wc.rb:95:in
>> `open'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:190:in
>> `test_entry':
>> <false> is not true.
>>
>> 6) Failure:
>> test_relocate(SvnWcTest)
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:981:in
>> `test_relocate'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/wc.rb:117:in
>> `_open'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/svn/wc.rb:101:in
>> `probe_open'
>> /Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/test/test_wc.rb:968:in
>> `test_relocate':
>> <[["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2",
>> nil],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> [nil,
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> [nil,
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1/hello.txt",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> [nil,
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> [nil,
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2/hello2.txt",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"]]>
>> expected but was
>> <[["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2",
>> nil],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1",
>> nil],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1/hello.txt",
>> nil],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir1/hello.txt",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2",
>> nil],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2/hello2.txt",
>> nil],
>> ["1446557e-444e-46f4-b33f-e570454e700c",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2/dir2/hello2.txt",
>> "file:///Users/mphippard/work/svn-trunk/subversion/bindings/swig/ruby/repos/dir2"]]>.
>>
>> 213 tests, 1442 assertions, 4 failures, 2 errors
>
> I am still getting these Ruby results with the patch committed. This
> would be as expected, so not really newsworthy. I just wanted to
> point out that the Perl tests now all run OK for me. It does not look
> like anything has been changed so maybe I had just need to do a make
> distclean or something?
>
> Anyway, I am running all of the tests right now, but it looks like
> these Ruby tests and the Serf tests are the only failing tests at the
> moment.

Glancing at the Ruby test output (and duplicating it myself), it appears that
some of them are conflict-related (tree or otherwise), and at least one is due
to the checksum changes in FSFS. I'm working on the checksum stuffs now, and
hopefully others are looking at the conflict failures.

I don't see any failures in the Perl or Python tests.

-Hyrum