[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r33872 - trunk/tools/dev

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Mon, 17 Nov 2008 09:55:35 -0600

Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-11-16 04:35:05 Hyrum K. Wright napisał(a):
>> Arfrever Frehtes Taifersar Arahesis wrote:
>>> 2008-10-23 23:54:17 hwright_at_tigris.org napisał(a):
>>>> Author: hwright
>>>> Date: Thu Oct 23 14:54:17 2008
>>>> New Revision: 33872
>>>> Log:
>>>> Include patches committed by partial committers in the contribulyzer. As
>>>> partial committers grow in the project, they usually commit their own patches
>>>> following a +1 from a full committer. Those patches required a 'Patch by' line
>>>> to show up on the contribulyzer, and this commit fixes that.
>>> Could you change contribulyze.py to include only patches which were committed
>>> outside of partial commiters' commit area?
>>> You can check for existence of 'Approved by:' line.
>> I suppose I could, but I really don't have the time or the inclination to do so.
>> Hmm, now that I think about it, that would require making the partial commit
>> area field parsable, which would probably hurt the human comprehension, and I'm
>> against that. However, if there's away to accomplish both, feel free.
> I suggested to use checking if svn:log contains 'Approved by:' line [1].
> IMHO this method would give sufficiently correct results.
> [1] http://subversion.tigris.org/hacking.html#partial-commit-access

Sounds like it would be possible, but we need to make sure we aren't guessing
here. I strongly feel that contribulyzer output should be as accurate as possible.

Also, regardless of whether it's technically possible, should be do this? I
mean, part of reason for the contribulyzer is to give us an idea of who
potential committers are. People which make regular commits to their own area
certainly fall underneath that consideration, so ignoring those commits on their
contribulyzer "score" may not be very wise. Just a thought.


Received on 2008-11-17 16:55:49 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.