[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Branching 1.6.x this week (dirent_uri)

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sat, 15 Nov 2008 22:41:33 +0100

Bert Huijben wrote:
>> -----Original Message-----
>> From: Lieven Govaerts [mailto:svnlgo{a}mobsol.be]
>> Sent: maandag 10 november 2008 20:32
>> To: dev_at_subversion.tigris.org
>> Subject: Re: Branching 1.6.x this week
>>
>>
>> So, I haven't had time to finish the dirent_uri stuff which I started
>> to
>> add during the month October. The problem is that the new interface
>> isn't finished, and AFAIC shouldn't be exposed yet.
>>
>> I don't have time to make this change in the coming days or weeks, so
>> I'd like to ask if someone can move the file dirent_uri.h out of the
>> public area (except for svn_dirent_is_root). That should do it
>> normally.
>> This gives me some time to finish it up before 1.7.
>
> Hi Lieven,
>
> What are the open issues on this? Is it possible for somebody else to
> resolve the few loose ends there are?
>

Well, since the svn_[dirent|uri] stuff is a whole new API, now might be
a good moment to make sure that API is better than the original. So,
things like passing a pool parameter, return svn_error_t on all
functions etc.

Besides that, the API is not complete yet. For some functions we have
the svn_uri variant but not svn_dirent or visa versa.
Then there is the is_absolute function, which thinks "E:foo" is an
absolute path.

> The code is in use in quite some places (the old public api uses the new
> functions), but there are other places that use the old api that indirectly
> calls svn_dirent*.

I thought only svn_dirent_is_root is used in other places than path.c.

>
> When I look through it, it seems most dirent and url public api's are
> completed, but are not used everywhere they should. Doing a massive rename
> to make the api internal just to make it public in 1.7 doesn't feel ok.
>

I'm more afraid that we'd introduce an API that isn't finished yet,
which we have to rev in 1.7. My plan was to deprecate svn_path* at the
same time as we introduce svn_[dirent|uri].

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-15 22:41:43 CET

This is an archived mail posted to the Subversion Dev mailing list.