Re: svn commit: r34213 - trunk/subversion/libsvn_fs_fs

On Nov 15, 2008, at 1:56 AM, Greg Stein wrote:

> On Fri, Nov 14, 2008 at 5:46 PM, <blair_at_tigris.org> wrote:
>> ...
>> +++ trunk/subversion/libsvn_fs_fs/tree.c Fri Nov 14 17:46:41
>> 2008 (r34213)
>> ...
>> @@ -1681,23 +1691,23 @@ svn_fs_fs__commit_txn(const char **confl
>> was the target of the merge (but note that the youngest rev
>> may have changed by then -- that's why we're careful to get
>> this root in its own bdb txn here). */
>> - SVN_ERR(get_root(&youngish_root_node, youngish_root, pool));
>> + SVN_ERR(get_root(&youngish_root_node, youngish_root,
>> iterpool));
>
> This SVN_ERR might exit the function without doing the pool
> destruction...
>
> (same with others, of course)

Yeah, I figured that was fine. We don't clean up most pools in case
of an error.

Should we change it?

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-15 20:37:00 CET