Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native

2008-11-12 17:13:49 Hyrum K. Wright napisał(a):
> I'm concerned about this change. I understand that it removes a deprecated
> function warning, but the warning is there for a purpose. The Right Way to
> solve this problem would be to allow JavaHL to provide the right callbacks for
> the updated APIs. Can we revert this change as a reminder to do it right?

OK. I reverted r34149 in r34194 :)

>
> -Hyrum
>
> arfrever_at_tigris.org wrote:
> > Author: arfrever
> > Date: Tue Nov 11 12:53:51 2008
> > New Revision: 34149
> >
> > Log:
> > Don't use deprecated functions in JavaHL.
> >
> > * subversion/bindings/javahl/native/SVNClient.cpp
> > (SVNClient::getContext): Use svn_auth_get_simple_provider2() instead of
> > svn_auth_get_simple_provider(). Use
> > svn_auth_get_ssl_client_cert_pw_file_provider2() instead of
> > svn_auth_get_ssl_client_cert_pw_file_provider().
> >
> > Modified:
> > trunk/subversion/bindings/javahl/native/SVNClient.cpp
> >
> > Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native/SVNClient.cpp?pathrev=34149&r1=34148&r2=34149
> > ==============================================================================
> > --- trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:20:55 2008 (r34148)
> > +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:53:51 2008 (r34149)
> > @@ -1217,7 +1217,7 @@ svn_client_ctx_t *SVNClient::getContext(
> > if (provider)
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> >
> > - svn_auth_get_simple_provider(&provider, pool);
> > + svn_auth_get_simple_provider2(&provider, NULL, NULL, pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > svn_auth_get_username_provider(&provider, pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > @@ -1233,7 +1233,8 @@ svn_client_ctx_t *SVNClient::getContext(
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > svn_auth_get_ssl_client_cert_file_provider(&provider, pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > - svn_auth_get_ssl_client_cert_pw_file_provider(&provider, pool);
> > + svn_auth_get_ssl_client_cert_pw_file_provider2(&provider, NULL, NULL,
> > + pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> >
> > if (m_prompter != NULL)
> >

-- 
Arfrever Frehtes Taifersar Arahesis