[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Wed, 12 Nov 2008 11:28:19 -0500

Mark Phippard wrote:
> On Wed, Nov 12, 2008 at 11:13 AM, Hyrum K. Wright
> <hyrum_wright_at_mail.utexas.edu> wrote:
>> I'm concerned about this change. I understand that it removes a deprecated
>> function warning, but the warning is there for a purpose. The Right Way to
>> solve this problem would be to allow JavaHL to provide the right callbacks for
>> the updated APIs. Can we revert this change as a reminder to do it right?
> I am not aware of all the code involved, but how are we able to use
> the new functions at all if it is not being done the "right way". If
> you are concerned, then I am concerned too.

The new functions take NULL arguments in place of the callbacks and basically
behave as the old functions, so there shouldn't be any functional change with
this patch.

However, these is work to be done, which is my concern, and the deprecated
warnings remind us of that. I've got a half-baked patch right now, but I'm not
really sure that is works or fits the existing JavaHL auth paradigm. I'm
holding off on committing it because I've got some more pressing items on my
plate, and I'd rather not commit a half-patch to trunk right now.

If another JavaHL guru (do we have any?) wants to look at this, be my guest.


Received on 2008-11-12 17:28:37 CET

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.