RE: svn commit: r34084 - trunk/subversion/libsvn_wc

On Fri, 2008-11-07 at 15:04 +0100, Bert Huijben wrote:
> > Log:
> > Correct a bug in the WC entries walker. In "show_hidden" mode, it tried
> > to
> > recurse into a 'deleted' or 'absent' directory.
> >
> > * subversion/libsvn_wc/entries.c
> > (walker_helper): Do not try to recurse into a 'deleted' or 'absent'
> > directory.
>
> I didn't review the workings of this patch, but on the WC level we usually see all children of deleted directories and I'm afraid we can't change this behavior.
> (Personally I would love to see a directory delete as a single delete action of the root and everything below like we do on the ra level)

The 'deleted' flag referred to here is not the same as schedule==delete.
Does that help?

- Julian

> I asked some questions on this subject at Subconf, but the option of committing a single file delete below a deleted directory was a feature. (This is also the root cause of the namespace collisions when replacing trees)

> > Modified: trunk/subversion/libsvn_wc/entries.c

> > @@ -3206,6 +3206,7 @@ walker_helper(const char *dirpath,
> >
> > /* Recurse into this entry if appropriate. */
> > if (current_entry->kind == svn_node_dir
> > + && !current_entry->deleted && !current_entry->absent
> > && depth >= svn_depth_immediates)
> > {

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-11-07 16:58:45 CET