Re: [PATCH] Refactor platform-specific auth provider access

Hi Jeremy,

2008/11/4 Jeremy Whitlock <jcscoobyrs_at_gmail.com>:
> Hi All,
> Over the last few weeks, there have been a few discussions related
> to platform-specific auth providers and how we should refactor them to
> make life easier for developers, bindings maintainers and API users:
>
> http://www.nabble.com/Configuring-encrypted-password-caching:-API-proposal-td20017581.html
> http://www.nabble.com/SWIG-and-platform-specific-auth-providers-(Was:-Python-bindings-build-seems-broken)-td20003744.html
>
> Basically, to summarize the proposal, there is a lot of
> platform-specific boilerplate code through parts of Subversion that
> use the auth providers. The proposal is to create a unified approach
> to access platform-specific auth providers to get rid of this
> boilerplate code and also the library juggling it requires. I have
> attached a patch that does just this. Basically, here is a high level
> of that this patch does to achieve the desired results:
>
> * Hide platform-specific auth providers from swig (perl, python and
> ruby) and ctypesgen (ctypes-python)
> * Create a single function for getting a platform-specific auth
> providers and put that function
> * Update the consumers of platform-specific providers to use the new API
>
> Now, you might be wondering why this wasn't done for all auth
> providers. In a later refactoring, it could be done but to get this
> in for 1.6, and finally fix the bindings once and for all, this made
> the most sense. (There is also a problem with some auth providers
> only working in certain scenarios like when you're using the command
> line client which would require even more potential refactoring.)
>
> Instead of just assuming this was the desired approach, I figured I
> would post this to the list and get a few more eyes on it. What do
> you think?
>

I reviewed mostly with an eye to the interface for bindings, but it
looks like a
good idea to me.

--
Joe
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org